serafim/free-programming-books
1
0
Fork 0
mirror of https://github.com/EbookFoundation/free-programming-books.git synced 2026-07-08 13:21:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix comment on PR workflow (#13188)

Browse Source 
* remove specific node version so default is 24

* change success to completed in comment pr workflow
This commit is contained in:
Leithen 2026-03-31 14:53:45 -06:00 committed by GitHub
parent 8206f6fce0
commit f026adec83
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/comment-pr.yml vendored
View File

@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
if: > if: >
${{ github.event.workflow_run.event == 'pull_request' && ${{ github.event.workflow_run.event == 'pull_request' &&
github.event.workflow_run.conclusion == 'success' }} github.event.workflow_run.conclusion == 'completed' }}
steps: steps:
- name: 'Download artifact' - name: 'Download artifact'
uses: actions/github-script@v8 uses: actions/github-script@v8

7
.github/workflows/fpb-lint.yml vendored
View File

@ -14,11 +14,9 @@ jobs:
- uses: actions/checkout@v5 - uses: actions/checkout@v5
- name: Use Node.js - name: Use Node.js
uses: actions/setup-node@v6 uses: actions/setup-node@v6
with:
node-version: '16.x'
- run: npm install -g free-programming-books-lint - run: npm install -g free-programming-books-lint
- name: Pull Request - name: Run linter
run: | run: |
fpb-lint books casts courses more &> output.log fpb-lint books casts courses more &> output.log
@ -29,7 +27,8 @@ jobs:
echo ${{ github.event.pull_request.html_url }} > ./pr/PRurl echo ${{ github.event.pull_request.html_url }} > ./pr/PRurl
cat output.log | sed -E 's:/home/runner/work/free-programming-books/|⚠.+::' | uniq > ./pr/error.log cat output.log | sed -E 's:/home/runner/work/free-programming-books/|⚠.+::' | uniq > ./pr/error.log
- uses: actions/upload-artifact@v7 - name: Upload artifact
uses: actions/upload-artifact@v7
if: always() if: always()
with: with:
name: pr name: pr